D18458: Rewrite the KWin decorations settings as a ConfigModule.

vpilo added a comment.


  In D18458#399851 <https://phabricator.kde.org/D18458#399851>, @ngraham wrote:
  
  > Cool stuff. I ran into some issues and have a few visual suggestions.
  >
  > 1. Applying the patch and building KWin didn't actually make the new KCM appear anywhere in System Settings for me. The old KCM was still there in its place.
  
  
  It's because now all new KCMs get installed in a different directory. Check where the new `kcm_kwindecoration.so` gets installed, and remove the same .so from the parent directory.
  
  `/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_kwindecoration.so` -> `/usr/lib/x86_64-linux-gnu/qt5/plugins/kcms/kcm_kwindecoration.so`
  
  On Ubuntu/Neon, after the test you can do `sudo apt install --reinstall kwin-common` to restore the original.
  
  > 2. Going by the screenshots, we should try to use the GridView style of other recently-rewritten KCMs, like Icons, Colors, Plasma theme etc
  
  done. Looks much nicer!
  
  > 3. Let's try to use the multi-page navigation pattern rather than tabs. QQC2 Tabs are full of visual problems right now, as your screenshots illustrate.
  
  I don't know what this pattern is; could you show me an example?
  The visual issues are fixed now, btw.
  
  > 4. Instead of creating a third tab/page for just two options, let;s move those back where they were before, as footers for the grid view.
  
  I'll make a new iteration for that
  
  > 5. "Get New Decorations" should retain its old text and position; it needs to say "Get New Window Decorations" and be in the bottom-right.
  
  Done
  
  In D18458#400197 <https://phabricator.kde.org/D18458#400197>, @davidedmundson wrote:
  
  > > I can not find a good way to avoid this issue, do you have time to help me a bit?
  >
  > Sure, no problem. Might be a few days though.
  
  
  Looks like I managed. Pesky. Thank you anyways!

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart