D18458: Rewrite the KWin decorations settings as a ConfigModule.

ngraham added a comment.


  Ah, thanks for the info. Now I can see it. Lovely work! I can't wait to ship this.
  
  A few new comments:
  
  - If you made the grid view delegates a bit smaller, we could fit two rows into the grid with System Settings' default window size.
  - The inline "Configure" buttons should match the Plasma Theme and Colors KCMs and say "Edit <theme name> Theme" and use the `edit-entry` icon.
  - By making the Edit/Configure button once again text-less, we'll be effectively reverting the fix for re-open https://bugs.kde.org/show_bug.cgi?id=390245, which was done in D11201 <https://phabricator.kde.org/D11201>. This is a general problem with these new-style KCMs that's tracked with https://bugs.kde.org/show_bug.cgi?id=395510, but it's worth maybe putting some more thought into that since the scope of the problem will expand as more KCMs are ported.
  - The tabbed view suffers from the problems outlined in https://bugs.kde.org/show_bug.cgi?id=394295 and https://bugs.kde.org/show_bug.cgi?id=394296. We really need to get those fixed...
  - On the Buttons page, the buttons are very difficult to see because everything is gray-on-gray: gray square background, gray shadow, gray icon, etc. We need radically more contrast here. For a start, I would remove the shadows. They don't add anything and reduce contrast.
  - Could we maybe change the name of the "Buttons" tab to "Titlebar Buttons" That would make it a bit more obvious, I think.
  - While you're re-doing this, let's change the `Comment` in the desktop file to say something different. The current string "Look and Feel of Window Titles" is not accurate and does not follow use the correct formatting (should be in Sentence case and begin with a verb). Maybe something like "Configure window shadows, borders, and titlebars". And then that string should be repeated in the `KAboutData` (or ideally it should just read the string from the desktop file instead of duplicating it in the code).
  
  Thanks again for your awesome work on this!

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart