D18458: Rewrite the KWin decorations settings as a ConfigModule.

ngraham added a comment.


  Now this is weird: when opened using System Settings > Application Style > Window Decorations it looks fine. But when opened using System Settings > [one of the five "recently used" buttons on the home page] it always looks like this for me:
  
  F6570980: Weird.png <https://phabricator.kde.org/F6570980>
  
  > I raise you "Configure window appearance, borders, and buttons"
  
  I think that would cause confusion, because this KCM is //not// for configuring window appearance in general; it's for configuring only what KWin provides: a titlebar, window borders, and a shadow.
  
  The Titlebar Buttons tab looks better now! I still think the shadows are unnecessary, but they aren't enough to cause contrast issues anymore.
  
  One nitpick: don't use a blue color for message text. That color means "I'm a link!", which it isn't in this context. Also, shouldn't that Close windows by double clicking the menu button checkbox stay where it is right now, on the Buttons/Titlebar Buttons tab?
  
  Here's another issue I just found: the Border Size combobox only seems to have two options: "No Borders" and "Oversized". This is particularly problematic given that the default setting of "Normal" is not present.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart