D18570: EGLStream DRM Backend Initial Implementation

graesslin added a comment.


  I really like that this is much more self contained than I expected. I haven't done an in depth review yet.

INLINE COMMENTS

> CMakeLists.txt:29
>  set_target_properties(KWinWaylandDrmBackend PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/org.kde.kwin.waylandbackends/")
> -target_link_libraries(KWinWaylandDrmBackend kwin Libdrm::Libdrm SceneQPainterBackend SceneOpenGLBackend)
> +target_link_libraries(KWinWaylandDrmBackend kwin Libdrm::Libdrm SceneQPainterBackend SceneOpenGLBackend dl wayland-server)
>  

Why are these two libraries needed?

> drm_backend.cpp:751
>  {
> +    if (m_useEglDevice) {
> +        m_deleteBufferAfterPageFlip = false;

Wouldn't it make more sense to try the available backends? E.g first create EglGbmBackend, if that fails create EglStreamBackend - comparable to how we load the compositor.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18570

To: ekurzinger, romangeints, davidedmundson, graesslin, #kwin
Cc: nicolasfella, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart