D18458: Rewrite the KWin decorations settings as a ConfigModule.

vpilo added a comment.


  In D18458#401153 <https://phabricator.kde.org/D18458#401153>, @ngraham wrote:
  
  > Now this is weird: when opened using System Settings > Application Style > Window Decorations it looks fine. But when opened using System Settings > [one of the five "recently used" buttons on the home page] it always looks like this for me:
  >
  > F6570980: Weird.png <https://phabricator.kde.org/F6570980>
  
  
  That is the layouting issue I asked @davidedmundson about (and everyone else, actually). I think I didn't do anything different than using a ColumnLayout instead of the usual Kirigami.FormLayout used in other SimpleKCM KCMs, but the gridview doesn't properly adapt to the window size. I checked in gammaray, and it's actually the entire root item of main.qml that doesn't expand properly.
  
  >> I raise you "Configure window appearance, borders, and buttons"
  > 
  > I think that would cause confusion, because this KCM is //not// for configuring window appearance in general; it's for configuring only what KWin provides: a titlebar, window borders, and a shadow.
  
  hmm then "Configure window titlebar, borders, buttons" as many themes have no shadows? If that's not an issue I'm fine with shadows too.
  
  > One nitpick: don't use a blue color for message text. That color means "I'm a link!", which it isn't in this context. Also, shouldn't that Close windows by double clicking the menu button checkbox stay where it is right now, on the Buttons/Titlebar Buttons tab?
  
  I can choose another more neutral color, ok.
  I guess I can selectively show one option or the other depending on the open tab. I'm afraid to add more stuff inside the tabs due to the layouting issues.
  
  > Here's another issue I just found: the Border Size combobox only seems to have two options: "No Borders" and "Oversized". This is particularly problematic given that the default setting of "Normal" is not present.
  
  Oh, this must be a qml bug, it works when placed elsewhere. Weird. You can still scroll through the values via the keyboard! I have no idea why this happens only when I put the combobox in the footer.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart