D18703: [kcmkwin] Split out Desktop Effects KCM

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  A while ago desktop effects and compositing settings lived under the
  same roof
  
  F6584639: snapshot1.png <https://phabricator.kde.org/F6584639>
  
  F6584642: snapshot2.png <https://phabricator.kde.org/F6584642>
  
  but time has passed and now those two have their own kcms. This causes
  some issues:
  
  - for newcomers it's harder to find code of the Desktop Effects KCM;
  - git history doesn't look good, e.g. "[kcmkwin/compositing] Add some bugs to Desktop Effects KCM to fix later";
  - in general, the mix of two doesn't look good in the code.
  
  This change splits out the Desktop Effects KCM. Unfortunately, in order
  to have more nicer code I had to refactor EffectModel a little bit.
  
  Before:
  
  F6584669: Screenshot_20190203_165833.png <https://phabricator.kde.org/F6584669>
  
  After:
  
  F6584647: Screenshot_20190203_164412.png <https://phabricator.kde.org/F6584647>

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18703

AFFECTED FILES
  kcmkwin/CMakeLists.txt
  kcmkwin/common/effectmodel.cpp
  kcmkwin/common/effectmodel.h
  kcmkwin/kwincompositing/CMakeLists.txt
  kcmkwin/kwincompositing/effectconfig.cpp
  kcmkwin/kwincompositing/effectconfig.h
  kcmkwin/kwincompositing/kcmkwineffects.desktop
  kcmkwin/kwincompositing/kwineffect.knsrc
  kcmkwin/kwincompositing/main.cpp
  kcmkwin/kwincompositing/model.cpp
  kcmkwin/kwincompositing/model.h
  kcmkwin/kwincompositing/qml/Effect.qml
  kcmkwin/kwincompositing/qml/EffectView.qml
  kcmkwin/kwincompositing/qml/Video.qml
  kcmkwin/kwincompositing/qml/main.qml
  kcmkwin/kwincompositing/test/effectmodeltest.cpp
  kcmkwin/kwincompositing/test/effectmodeltest.h
  kcmkwin/kwincompositing/test/modeltest.cpp
  kcmkwin/kwincompositing/test/modeltest.h
  kcmkwin/kwineffects/CMakeLists.txt
  kcmkwin/kwineffects/Messages.sh
  kcmkwin/kwineffects/effectsfilterproxymodel.cpp
  kcmkwin/kwineffects/effectsfilterproxymodel.h
  kcmkwin/kwineffects/kcm.cpp
  kcmkwin/kwineffects/kcm.h
  kcmkwin/kwineffects/kcm_kwin_effects.desktop
  kcmkwin/kwineffects/kwineffect.knsrc
  kcmkwin/kwineffects/package/contents/ui/Effect.qml
  kcmkwin/kwineffects/package/contents/ui/Video.qml
  kcmkwin/kwineffects/package/contents/ui/main.qml
  kcmkwin/kwineffects/package/metadata.desktop

To: zzag, #kwin
Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart