D18704: [kcmkwin] Add requestConfigure to effects model
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. zzag requested review of this revision. REVISION SUMMARY The main motivation for adding this method is to avoid code duplication. Both virtual desktops kcm and desktop effects kcm have their own logic to create configuration dialogs for effects. On the bright side, if we add support for declarative effect kcms, we will need to change only this method. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D18704 AFFECTED FILES kcmkwin/common/effectmodel.cpp kcmkwin/common/effectmodel.h kcmkwin/kwindesktop/virtualdesktops.cpp kcmkwin/kwineffects/kcm.cpp To: zzag, #kwin Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart