D18465: [platforms/wayland] Multi output support

davidedmundson added a comment.


  Looks good.

INLINE COMMENTS

> egl_wayland_backend.cpp:243
> +
> +    // TODO: viewport is experimental, see comments in EglGbmBackend
> +    const QSize &overall = screens()->size();

I don't think that's true anymore. I did lots of fixes to it.
We can remove that comment

> egl_wayland_backend.cpp:244
> +    // TODO: viewport is experimental, see comments in EglGbmBackend
> +    const QSize &overall = screens()->size();
> +    const QRect &v = output->m_waylandOutput->geometry();

Use of temporary values is weird.

> egl_wayland_backend.cpp:311
>      // The back buffer contents are now undefined
> -    m_bufferAge = 0;
> +    for (auto output : m_outputs) {
> +        output->m_bufferAge = 0;

qAsConst

(in both places)

> wayland_backend.cpp:449
>      , m_compositor(new KWayland::Client::Compositor(this))
> +    , m_subCompositor(new KWayland::Client::SubCompositor(this))
>      , m_shell(new Shell(this))

where do we use this?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18465

To: romangg, #kwin
Cc: davidedmundson, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart