D18458: Rewrite the KWin decorations settings as a ConfigModule.

vpilo added a comment.


  In D18458#405339 <https://phabricator.kde.org/D18458#405339>, @davidedmundson wrote:
  
  > > Is this patch acceptable
  >
  > In general, yes.
  >
  > > while we work out another fix,
  >
  > Lets just fix it together whilst we're still thinking about it.
  >  Try this: https://phabricator.kde.org/D18739
  >
  >  ----
  >
  > > Or that all *KCM items should inherit from SimpleKCM
  >
  > We don't want to inherit from SimpleKCM.
  >
  > SimpleKCM adds a scrollbar. It's not claiming it's a simple class, it's for use when the contents are simple.
  >
  > In GridViewKCM only the grid scrolls, so we don't need scrollbars round the rest.
  
  
  @davidedmundson - I tried that fix, and removed the paddings from this patch's `main.qml`. The result is that both on KCMShell and SystemSettings I can see an extra 6 pixel margin around the main Page. In other words, the Frame's sides have now exactly 6 pixels of padding vs the buttons below (Apply, Defaults, Reset).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, #kwin, davidedmundson
Cc: zzag, GB_2, ngraham, broulik, kwin, jraleigh, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart