D18583: [WIP] Init ShellClient only when commited to the buffer

zzag added a comment.


  I have several comments, feel free to ignore them until this revision is good enough for landing:
  
  - it would be better to just call blockRequestGeometry and unblockRequestGeometry instead of using RAII because we don't actually benefit from it. Also, we have a field that is used only once, during initialization;
  - some of my frame callback comments are still not addressed, e.g. initXdgShellSurface and testQuickTiling. This can fire back at us in some tests;
  - would it make sense to add testXdgInitiallyMinimized as well?
  - given what RequestGeometryBlocker is doing, could you please add a todo item to rename it to ConfigureBlocker? We would address it after wl-shell support is dropped.
  
  I'm particularly excited about this change because it would let us implement all xdg popup constraints. Anyway, good stuff. :-)
  
  ---
  
  As far as I understand, we'll stick with the current approach. Emitting surfaceCreated after the surface is committed is out of scope, right?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18583

To: davidedmundson, #kwin
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart