D18570: EGLStream DRM Backend Initial Implementation

romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> abstract_egl_backend.cpp:130
>  
> +bool AbstractEglBackend::queryWaylandBufferWL(wl_resource *buffer,
> +                                              EGLint attribute, EGLint *value)

Put this function in EglStreamBackend only. On another note, do we need it at all? It's called only once.

> drm_backend.cpp:768
> +#endif
> +    {
>  #if HAVE_GBM

`else` keyword and curly braces are unnecessary.

> drm_backend.cpp:807
> +#if HAVE_GBM || HAVE_EGL_STREAMS
>      return QVector<CompositingType>{OpenGLCompositing, QPainterCompositing};
>  #else

In case of `HAVE_EGL_STREAMS` not if `m_useEglStreams` is false.

> drm_output.h:27
>  #include "drm_object_plane.h"
> +#include "drm_object_crtc.h"
>  

Remove. Forward declaration is enough.

> egl_stream_backend.h:87
> +    KWayland::Server::EglStreamControllerInterface *m_eglStreamControllerInterface;
> +    QHash<wl_resource *, StreamTexture> m_streamTextures;
> +

Instead of taking the wl_resource pointer as key, use the KWayland::Server::SurfaceInterface pointer.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18570

To: ekurzinger, davidedmundson, graesslin, #kwin, romangg
Cc: fredrik, cfeck, rapiteanu, romangg, hein, nicolasfella, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart