D18583: [WIP] Init ShellClient only when commited to the buffer

davidedmundson added a comment.


  I don't want to use AbstractClient::blockGeometryUpdates as it doesn't just call configure when it's done, it goes into setGeometry which is subtly different, especially for the code path where toplevels should choose their own size.
  
  I could refactor ShellClient::RequestGeometryBlocker to call into some new method on ShellClient when it destructs, which finishInit could then call directly.
  I'm not really convinced it's better, as we're probably still going to want some field to know we're in this state.
  
  > As far as I understand, we'll stick with the current approach. Emitting surfaceCreated after the surface is committed is out of scope, right?
  
  Yeah, I think that would introduce more problems than it solves and we'd probably still end up needing a geometryblocker to process all the different initial states happening in different orders.
  
  One compromise maybe worth considering is putting a signal in ShellClient emitted after the first surface commit.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18583

To: davidedmundson, #kwin
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart