D18583: [WIP] Init ShellClient only when commited to the buffer

davidedmundson updated this revision to Diff 51604.
davidedmundson added a comment.


  Update
  
  With the other related patches, popups work, all unit tests pass \o/
  Been using it on my machine for a day without issue.
  
  Patch doesn't include all zzag requests, happy to discuss and changing, just 
  updating what I have on here now with everything working well.
  
  Popups are positioned twice, which isn't ideal, but I think unavoidable.
  Hypotheticaly situations could have changed between creating the shell and
  the first map - or the popup could attach a buffer at different size.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18583?vs=51244&id=51604

BRANCH
  popupplacement2

REVISION DETAIL
  https://phabricator.kde.org/D18583

AFFECTED FILES
  autotests/integration/effects/maximize_animation_test.cpp
  autotests/integration/kwin_wayland_test.h
  autotests/integration/quick_tiling_test.cpp
  autotests/integration/shell_client_test.cpp
  autotests/integration/test_helpers.cpp
  shell_client.cpp
  shell_client.h

To: davidedmundson, #kwin
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart