D18818: virtualkeyboard: resize the focused window to make room for the keyboard

davidedmundson accepted this revision.
davidedmundson added inline comments.

INLINE COMMENTS

> move_resize_window_test.cpp:982
> +
> +    // render at the new size
> +    Test::render(surface.data(), configureRequestedSpy.last().first().toSize(), Qt::blue);

This line is a bit misleading, there isn't a new size requested.

You're resizing to a configure request from ages ago.

Arguably it's a nice test to show that the window hasn't moved afterwards, so maybe leave the code and change this comment.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18818

To: mart, #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Cc: nicolasfella, mart, kwin, davidedmundson, graesslin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol