D19905: [platforms/drm] Rework ScopedDrmPointer
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.
REVISION SUMMARY
Currently there is no any good reason for keeping ScopedDrmPointer;
providing our own deleter for QScopedPointer would make more sense.
Given that we already have type that acts as a scoped pointer for drm
objects we can improve it a bit and make simpler, e.g.
DrmScopedPointer<drmModeConnector> connector;
is much simpler than
ScopedDrmPointer<_drmModeConnector, &drmModeFreeConnector> connector;
REPOSITORY
R108 KWin
BRANCH
rework-drm-scoped-pointer
REVISION DETAIL
https://phabricator.kde.org/D19905
AFFECTED FILES
plugins/platforms/drm/drm_backend.cpp
plugins/platforms/drm/drm_object.cpp
plugins/platforms/drm/drm_object_connector.cpp
plugins/platforms/drm/drm_object_crtc.cpp
plugins/platforms/drm/drm_object_plane.cpp
plugins/platforms/drm/drm_output.cpp
plugins/platforms/drm/drm_output.h
plugins/platforms/drm/drm_pointer.h
To: zzag, #kwin
Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart