D19207: [platforms/x11/windowed] Port to AbstractOutput

zzag added a comment.


  In general, +1, though useractions popup has very small text now.
  
  F6794789: Screenshot_20190426_143631.png <https://phabricator.kde.org/F6794789>

INLINE COMMENTS

> x11windowed_backend.cpp:242-245
> +            auto it = std::find_if(m_outputs.constBegin(), m_outputs.constEnd(),
> +                                   [event] (X11WindowedOutput *output) { return output->window() == event->event; }
> +                      );
> +            if (it == m_outputs.constEnd()) {

Do you think it would be worth to introduce a method that can be used for querying an output with a given xcb_window_t? i.e.

X11WindowedOutput *X11WindowedBackend::findOutput(xcb_window_t id) const;

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D19207

To: romangg, #kwin
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart