D19208: [platforms/x11/standalone] Port to AbstractOutput

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added a comment.


  I don't quite like that XRandRScreens::update() was moved to the platform code, but I guess we could revisit it later on.

INLINE COMMENTS

> abstract_output.h:5
>  
> -Copyright 2018 Roman Gilg <[email protected]>
> +Copyright 2019 Roman Gilg <[email protected]>
>  

I think it should be "2018, 2019"

> CMakeLists.txt:262-264
> +#TODO: Testing XRandRScreens does not work anymore with
> +#      using X11Output tightly integrated to Platform.
> +#      Remove this test?

No, I think we should keep the test. How about turning TestXRandRScreens into an integration test instead?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D19208

To: romangg, #kwin
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.