D13284: [decorations] Let KDecoration plugins recommend a border size per default

Pino Toscano <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
pino added inline comments.

INLINE COMMENTS

> decorationbridge.cpp:316
>      b.append(QStringLiteral("Theme: %1\n").arg(m_theme));
> +    b.append(QStringLiteral("Plugin recommends border size: %1\n").arg(m_recommendedBorderSize > 0 ? QString(m_recommendedBorderSize) : "No"));
>      b.append(QStringLiteral("Blur: %1\n").arg(m_blur));

how this line even works? m_recommendedBorderSize is a QString, so most probably the "> 0" is comparing it to a null char const*...
also, creating a new QString copying m_recommendedBorderSize is not needed

REPOSITORY
  R108 KWin

BRANCH
  borderSizeRecommend

REVISION DETAIL
  https://phabricator.kde.org/D13284

To: romangg, #kwin, #plasma, #vdg, ngraham
Cc: pino, filipf, anemeth, davidedmundson, abetts, graesslin, ngraham, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.