D20937: Handle XdgShell window geometry in configure request sizes
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in shell_client_test.cpp:1484 > Please wrap in QVERIFY. > > Also, would it be a good idea to have an explicit configureRequestedSpy.wait() right after renderAndWaitFotShown? Adding there is a slightly tricky case, the configure event after renderAndWaitForShown is just kwin activating the window. Something that happens with current kwin, but not a requirement that we want to be testing. I'll add it with a comment and not qverify it. > zzag wrote in shell_client_test.cpp:1492-1493 > If we add support for window rules, would geometry rules work well with GTK+ clients? Before this patch: No After this patch: Also no, but support will become easier to add. The attached task hopefully lists plans. I can expand on any rationale/details there. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D20937 To: davidedmundson, #kwin Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart