D19262: Delayed focus updates for Toplevels without surface

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  Naming nitpick: I suggest to rename m_at.at to m_at.toplevel in order to avoid repetition.

INLINE COMMENTS

> input.cpp:2268
> +
> +    if (m_at.at && !m_at.at->surface()) {
> +        if (!m_at.surfaceCreatedConnection) {

Can you leave a comment that explains why we do this?

> input.h:456
> +        QPointer<Toplevel> at;
> +        QMetaObject::Connection surfaceCreatedConnection;
> +    } m_at;

Given that you connect to surfaceChanged, perhaps it should be surfaceChangedConnection.

REPOSITORY
  R108 KWin

BRANCH
  bpmFocusFix

REVISION DETAIL
  https://phabricator.kde.org/D19262

To: romangg, #kwin, zzag
Cc: anthonyfieroni, davidedmundson, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart