D21076: ICC Color Correction Effect

vitaliyf added a comment.


  Yes, I know. I even tested it 5 or 6 years ago. I think that implementation was really clunky because it depended on Oyranos which is unavailable in most distros, and instead of being implemented as an effect it was patching shader code of other effects before compiling them. There was a whole 2 or 3 screen long function that was doing it. My implementation is much simpler and it only depends on LCMS2.
  
  Please merge single-screen color correction first :) it's very useful at least for a lot of laptops. In fact it's a unique feature, neither Windows nor Macos has it. I think anyway it's better to have single-screen color correction that no correction at all :)
  
  Also I see there's WindowPaintData::screen() so it's probably possible to select different shaders on a per-window basis. So it should be easy to implement multi-screen correction if it actually works.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D21076

To: vitaliyf
Cc: zzag, ngraham, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart