D13284: [decorations] Let KDecoration plugins recommend a border size per default
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments.
INLINE COMMENTS
> decorationbridge.cpp:230
> }
> + auto recBorderSizeIt = decoSettingsMap.find(QStringLiteral("recommendedBorderSize"));
> + if (recBorderSizeIt != decoSettingsMap.end()) {
No short names.
> decorationbridge.cpp:316
> b.append(QStringLiteral("Theme: %1\n").arg(m_theme));
> + b.append(QStringLiteral("Plugin recommends border size: %1\n").arg(m_recommendedBorderSize.isNull() ? "No" : m_recommendedBorderSize));
> b.append(QStringLiteral("Blur: %1\n").arg(m_blur));
QStringLiteral("No")
> settings.cpp:189
> + if (m_autoBorderSize) {
> + /* Falls back to Normal border size, if the plugin does not provide a valid recommendation. */
> + size = stringToSize(DecorationBridge::self()->recommendedBorderSize());
For consistency sake, it has to be a single line comment.
REPOSITORY
R108 KWin
BRANCH
borderSizeRecommend
REVISION DETAIL
https://phabricator.kde.org/D13284
To: romangg, #kwin, #plasma, #vdg, ngraham
Cc: pino, filipf, anemeth, davidedmundson, abetts, graesslin, ngraham, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart