D21076: ICC Color Correction Effect
Vitaliy Filippov <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
vitaliyf marked 5 inline comments as done. vitaliyf added inline comments. INLINE COMMENTS > anthonyfieroni wrote in icc.cpp:113-118 > Don't use goto and custom allocations, use QScopedPointer on pointer type (also notice custom deleters https://doc.qt.io/qt-5/qscopedpointer.html#custom-cleanup-handlers), vector on arrays. OK, I changed uint8_t* to std::vector<uint8_t>. But how to do it with cmsHPROFILE? It's probably a pointer type, but it's internal to the LCMS2 library. How to wrap it in a QScopedPointer, and are you sure it must be wrapped? I think it will only complicate the code... It's local to this exact function, so is it a big problem that it's allocated with custom code?.. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D21076 To: vitaliyf Cc: davidedmundson, anthonyfieroni, zzag, ngraham, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart