D25207: [libkwineffects] Construct correct mouse event when forwarding to QtQuickView

Vlad Zahorodnii <[email protected]> Wed, 13 Nov 2019 17:59:46 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kwineffectquickview.cpp:206
> No specific reason. No compiler will complain about its presence either. 
> It's the same thing.

Okay, I see. Could you please drop these `Q_FALLTHOUGH` macros? There are a couple of reasons to do that:

(a) Putting `Q_FALLTHOUGH` or `[[fallthrough]]` in empty case blocks is uncommon
(b) It saves some vertical space

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25207

To: davidedmundson, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart