D24457: [wayland] Ensure that repaints_region is in frame-local coordinates

David Edmundson <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
davidedmundson added a comment.


  Let me try and explain my point again.
  
  In one invocation of TopLevel::addDamage the argument is relative to the buffer  (when we connect events from the wayland surface to here)
  In another invocation of TopLevel::addDamage the argument is relative to the frame  (when we're in the overridden implementation calling the base implementation)
  
  I am saying having one method defined where the argument semantics change depend on where it's called from is confusing.
  
  (That was the state before this patch too, I was just commenting on it whilst I saw it... )

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24457

To: zzag, #kwin, romangg
Cc: davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.