D26040: [KCM/Effects] Allow the user to know when the settings are set to default

Kevin Ottens <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
ervin added inline comments.

INLINE COMMENTS

> effectsmodel.cpp:569
> +    return std::all_of(m_effects.constBegin(), m_effects.constEnd(), [](const EffectData &effect) {
> +        if (effect.enabledByDefaultFunction && effect.status != Status::EnabledUndeterminded) {
> +            return false;

I suspect this lambda would have benefited from being a single return statement (not 100% sure though)

> effectsmodel.cpp:572
> +        }
> +        if ((bool)effect.status != effect.enabledByDefault) {
> +            return false;

Urgh! C-style cast, please don't. Should be a static_cast or something.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D26040

To: meven, #kwin, crossi, ervin, zzag
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.