D26040: [KCM/Effects] Allow the user to know when the settings are set to default
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > ervin wrote in effectsmodel.cpp:572 > Urgh! C-style cast, please don't. Should be a static_cast or something. Agreed, using it in modern C++ code is not good but on the other hand we have `(bool)effect.status != effect.enabledByDefault` just right above this method. If my memory serves me well, the c-style cast is leftover from the monolithic compositing kcm. This minor issue can be addressed in another patch though... REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D26040 To: meven, #kwin, crossi, ervin, zzag Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart