D27477: KCM/Kwinoptions: Port title bar and window actions tabs UI and conf to KConfigXT

Kevin Ottens <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> mouse.cpp:139
>  
> -KTitleBarActionsConfig::KTitleBarActionsConfig(bool _standAlone, KConfig *_config, QWidget * parent)
> -    : KCModule(parent), config(_config), standAlone(_standAlone)
> +KTitleBarActionsConfig::KTitleBarActionsConfig(bool _standAlone, QWidget * parent)
> +    : KCModule(parent), standAlone(_standAlone)

Please use the opportunity to remove the space after the *

> mouse.cpp:159
>  
>  KTitleBarActionsConfig::~KTitleBarActionsConfig()
> +{}

I guess it could be completely removed

> mouse.cpp:207
>  
>  KWindowActionsConfig::~KWindowActionsConfig()
> +{}

ditto

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27477

To: meven, crossi, bport, ervin, #kwin
Cc: kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.