D28283: Remove overloads on virtual methods
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > abstract_client.cpp:713 > if (area.width() < width() || area.height() < height()) > - resizeWithChecks(qMin(area.width(), width()), qMin(area.height(), height())); > + resizeWithChecks(area.size().boundedTo(size())); > } I'd swap `size()` and `area.size()` so when the code is read by someone it's easier to understand what we do. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D28283 To: apol, #kwin, zzag Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart