D28293: [kcmkwin] Make dialog non blocking
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments.
INLINE COMMENTS
> effectsmodel.cpp:669-671
> + connect(dialog, &QDialog::accepted, module, [module]() {
> module->save();
> + });
The lambda is redundant. I think you could just connect KCModule::save() directly, e.g.
connect(dialog, &QDialog::accepted, module, &KCModule::save);
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28293
To: davidedmundson, #kwin, apol
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart