D27784: KCM KWinTabBox manage KCModule states

Kevin Ottens <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
ervin added inline comments.

INLINE COMMENTS

> main.cpp:419
>  {
> -    CHECK_CURRENT_TABBOX_UI
> +    auto form = qobject_cast<KWinTabBoxConfigForm *>(sender());
>  

Too bad you lost the Q_ASSERT(form) in the process. It's all the more important now that we're using the evil sender(). :-)

Could we please have the assert back?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27784

To: crossi, #kwin, ervin, bport, meven, zzag
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.