D27955: KCM/Compositing: Use KConfig XT to store values
Kevin Ottens <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
ervin accepted this revision. ervin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > zzag wrote in compositing.cpp:80 > Heh, `- 4` and `+ 4` were obscure before so this patch doesn't make things better or worse. Just for context, we add and subtract 4 because long time ago `HiddenPreviews` had values with different meaning than what we have now. In order to break backwards compatibility, the new values were shifted by 4. And we didn't wrap that in conversion functions? :-) REPOSITORY R108 KWin BRANCH arcpatch-D27955 REVISION DETAIL https://phabricator.kde.org/D27955 To: meven, #kwin, ervin, bport, crossi, hchain, zzag Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart