D28152: KWinRules KCM Redesign
Ismael Asensio <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
iasensio updated this revision to Diff 79615. iasensio marked 2 inline comments as done. iasensio added a comment. Following @broulik's suggestions, now the rules list uses a full model based on QAbstractListModel, and a QPersistentModelIndex to store which rule is currently edited. This adds a little bit of boilerplate to set-up the model, but the code is much more robust and the UI responsiveness and feeling has improved a lot. - Simplify OptionsComboBox - Implemet RuleBookModel - Nicer UX when reordering rules REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28152?vs=79543&id=79615 BRANCH wip/rulebookmodel REVISION DETAIL https://phabricator.kde.org/D28152 AFFECTED FILES kcmkwin/kwinrules/CMakeLists.txt kcmkwin/kwinrules/detectwidget.cpp kcmkwin/kwinrules/detectwidget.h kcmkwin/kwinrules/detectwidget.ui kcmkwin/kwinrules/editshortcut.ui kcmkwin/kwinrules/kcm.cpp kcmkwin/kwinrules/kcm.h kcmkwin/kwinrules/kcm_kwinrules.desktop kcmkwin/kwinrules/kcmrules.cpp kcmkwin/kwinrules/kcmrules.h kcmkwin/kwinrules/kwinrules.desktop kcmkwin/kwinrules/main.cpp kcmkwin/kwinrules/optionsmodel.cpp kcmkwin/kwinrules/optionsmodel.h kcmkwin/kwinrules/package/contents/ui/FileDialogLoader.qml kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml kcmkwin/kwinrules/package/contents/ui/RulesList.qml kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml kcmkwin/kwinrules/package/metadata.desktop kcmkwin/kwinrules/rulebookmodel.cpp kcmkwin/kwinrules/rulebookmodel.h kcmkwin/kwinrules/ruleitem.cpp kcmkwin/kwinrules/ruleitem.h kcmkwin/kwinrules/rulesdialog.cpp kcmkwin/kwinrules/rulesdialog.h kcmkwin/kwinrules/ruleslist.cpp kcmkwin/kwinrules/ruleslist.h kcmkwin/kwinrules/ruleslist.ui kcmkwin/kwinrules/rulesmodel.cpp kcmkwin/kwinrules/rulesmodel.h kcmkwin/kwinrules/ruleswidget.cpp kcmkwin/kwinrules/ruleswidget.h kcmkwin/kwinrules/ruleswidgetbase.ui kcmkwin/kwinrules/yesnobox.cpp kcmkwin/kwinrules/yesnobox.h To: iasensio, #plasma, #kwin, #vdg Cc: davidedmundson, hchain, broulik, zzag, kwin, dmenig, manueljlin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, mkulinski, trickyricky26, ragreen, jackyalcine, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart