D28667: [platforms/x11] Fix valigrind warning copying window icon for windowed mode

David Edmundson <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  windowIcon.pixmap().bits() creates and deletes the QPixmap object.
  
  Which means data is dangling when we call m_winInfo->setIcon()
  
  Surprisingly harmless in real life.

TEST PLAN
  Reran kwin_wayland on X11 with valigrind

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28667

AFFECTED FILES
  plugins/platforms/x11/windowed/x11windowed_output.cpp

To: davidedmundson, #kwin
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.