D29459: Scripting: Make client.activities writable
Tiago CorrĂȘa <[email protected]> Fri, 4 Sep 2020 14:35:14 +0000
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
tcorreabr added inline comments. INLINE COMMENTS > meven wrote in abstract_client.h:888 > Shouldn't activitiesChanged be `activitiesChanged()` instead of `activitiesChanged(KWin::AbstractClient* client);` or `activitiesChanged(KWin::Toplevel* topLevel);` I don't see the necessity of the parameter either, but I'm not an KWin expert. Can I submit the change or does anyone think differently? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D29459 To: tcorreabr, #kwin, zzag Cc: meven, abetts, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, sebas, apol, ahiemstra, mart