D29459: Scripting: Make client.activities writable

Vlad Zahorodnii <[email protected]> Fri, 4 Sep 2020 15:19:53 +0000
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added inline comments.

INLINE COMMENTS

> tcorreabr wrote in abstract_client.h:888
> I don't see the necessity of the parameter either, but I'm not an KWin expert. Can I submit the change or does anyone think differently?

I suggest to just remove activitiesChanged() signal in the Toplevel class. Is there any chance that you open a MR over here https://invent.kde.org/plasma/kwin/ ?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29459

To: tcorreabr, #kwin, zzag
Cc: meven, abetts, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, sebas, apol, ahiemstra, mart