Broken commits in KDE PIM

Nicolas Fella <[email protected]> Sun, 13 Oct 2024 23:35:37 +0200
Newsgroups gmane.comp.kde.devel.pim
Message-ID <[email protected]> 
This is a multi-part message in MIME format.
--------------aqSJ9EgomDj06ocjghFN3Wn3
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Hi,

I just had to revert four "it compiles fine without kf deprecated
method" commits because it was not, in fact, compiling fine (which could
be seen on CI).

I find it rather concerning that such changes are pushed without proper
testing, and it find it even more concerning that when the CI is broken
things don't get fixed.

Furthermore the actual change is conceptually wrong too:

-ecm_set_disabled_deprecation_versions(QT 6.7.2 KF 6.7.0)
+ecm_set_disabled_deprecation_versions(QT 6.7.2 KF 6.8.0)

Frameworks 6.8 is still in development, so if we added any new
deprecations there it would cause an immediate build failure, which is
obviously very bad. ecm_set_disabled_deprecation_versions must never be
set to a future version for this reason.

Please take the necessary care when doing such changes in the future.

Cheers

Nico

--------------aqSJ9EgomDj06ocjghFN3Wn3
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Hi,</p>
    <p>I just had to revert four "it compiles fine without kf deprecated
      method" commits because it was not, in fact, compiling fine (which
      could be seen on CI).</p>
    <p>I find it rather concerning that such changes are pushed without
      proper testing, and it find it even more concerning that when the
      CI is broken things don't get fixed.</p>
    <p>Furthermore the actual change is conceptually wrong too:</p>
    <p><span style="font-family:monospace"><span
          style="color:#b21818;background-color:#ffffff;">-ecm_set_disabled_deprecation_versions(QT
          6.7.2 KF 6.7.0)</span><span
          style="color:#000000;background-color:#ffffff;">
        </span><br>
        <span style="color:#18b218;background-color:#ffffff;">+ecm_set_disabled_deprecation_versions(QT
          6.7.2 KF 6.8.0)</span><br>
      </span></p>
    <p>Frameworks 6.8 is still in development, so if we added any new
      deprecations there it would cause an immediate build failure,
      which is obviously very bad. ecm_set_disabled_deprecation_versions
      must never be set to a future version for this reason.</p>
    <p>Please take the necessary care when doing such changes in the
      future.</p>
    <p>Cheers</p>
    <p>Nico<br>
    </p>
  </body>
</html>

--------------aqSJ9EgomDj06ocjghFN3Wn3--