Re: gwenview2 exif patch
Aurélien Gâteau <[email protected]>
| Newsgroups | gmane.comp.kde.gwenview |
|---|---|
| Message-ID | <[email protected]> |
On Wednesday 29 August 2007 00:03:09 Aurélien Gâteau wrote: > On Sunday 19 August 2007 23:28:16 Carles Pina i Estany wrote: > > Hello, > > > > I send a patch for Gwenview 2. > > > > It will show Exif informatoion in full screen OSD. > > [snip] > Thanks for the patch. No time to have a look at it this evening, will > review it tomorrow. Hello again I had a look at it, but I don't think it's the way it should be done (I hope you don't mind). So I sat down and thought about it for a while. I ended up adding an exiv2Image() accessor to the Document class, returning an Exiv2::Image pointer. This Exiv2::Image is initialized while loading, before actually decoding image pixels. The Document::metaDataLoaded() signal is emitted when meta data is available. I used this to show some Exif info in the sidebar. It would be really great if you could implement the meta info display in the fullscreen bar based on this code. There is a schedule problem, though: KDE4 is in feature freeze now. I just requested a feature freeze exemption until beta3 so that we have time to implement this and a few other things. I'll keep the list posted about how it turns out. Aurélien PS: little Qt trick: you almost never need to create QString objects on the heap. QString is implicitly shared, so you can safely return them as value, and it's cheap to copy them. Have a look at the QString doc for more info. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Gwenview-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/gwenview-general