Re: gwenview2 exif patch

Hello,

On Aug/31/2007, Aurélien Gâteau wrote:
> On Wednesday 29 August 2007 00:03:09 Aurélien Gâteau wrote:
> > On Sunday 19 August 2007 23:28:16 Carles Pina i Estany wrote:

> > [snip]
> > Thanks for the patch. No time to have a look at it this evening, will
> > review it tomorrow.

> I had a look at it, but I don't think it's the way it should be done (I hope 
> you don't mind).

no problem! I'm sure that you know more than me about software design
and specifically gwenview design :-) (bit difficult without diagrams :-)
)

Also, in my experience, when something has too much problems (like I
had, synchronizing image loading and Exiv loading, etc.) is because a
bad design.

> So I sat down and thought about it for a while. I ended up adding an 
> exiv2Image() accessor to the Document class, returning an Exiv2::Image 
> pointer. This Exiv2::Image is initialized while loading, before actually 
> decoding image pixels. The Document::metaDataLoaded() signal is emitted when 
> meta data is available.

looks much cleaner than my one, better!

> I used this to show some Exif info in the sidebar. It would be really
> great if  you could implement the meta info display in the fullscreen
> bar based on this code.

I think that during weekend I will take a look. I cannot promise, I have
some things to prepare... but no problem.

> There is a schedule problem, though: KDE4 is in feature freeze now. I
> just requested a feature freeze exemption until beta3 so that we have
> time to implement this and a few other things. I'll keep the list
> posted about how it turns out.

yes, but anyway I think that there is other things (beside Exif) that
should be fixed before. Like:

-Enable/disable thumbails
-Loading speed (?)
-Gwenview 2.x was eating 200 MB of memory when I opened in
very populated directory (and taking endless)
-To move the image ("drag and drop" the image, I expect that image is
moved)
-... is there any list? :-)

> PS: little Qt trick: you almost never need to create QString objects
> on the heap. QString is implicitly shared, so you can safely return
> them as value, and it's cheap to copy them. Have a look at the QString
> doc for more info.

Thanks! I'll take a look!

-- 
Carles Pina i Estany		GPG id: 0x8CBDAE64
	http://pinux.info	Manresa - Barcelona

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/