Re: Review Request 128707: Add support for captive portals

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/
-----------------------------------------------------------

(Updated Zář. 14, 2016, 7:05 dop.)


Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza.


Changes
-------

Use a bit different approach suggested by David Edmunson. Instead of opening our own web view using QWebEngine, we can use user's browser directly, with that we have a benefit of stored passwords. I also added a notification which will be opened when a captive portal is detected and user can decide whether to open his browser and log in or not.


Bugs: 365417
    http://bugs.kde.org/show_bug.cgi?id=365417


Repository: plasma-nm


Description
-------

Adds portal monitor to our kded module, which checks NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive portal), then we open a QWebEngineView trying to load "http://kde.org" page which is supposed to be redirected to the captive portal page. Once user logs in and url changes, we re-check the connectivity again and close the web view if we are no longer behind the captive portal.


Diffs (updated)
-----

  kded/CMakeLists.txt 1f0613e 
  kded/networkmanagement.notifyrc f95d94b 
  kded/portalmonitor.h PRE-CREATION 
  kded/portalmonitor.cpp PRE-CREATION 
  kded/service.cpp 18ffd41 

Diff: https://git.reviewboard.kde.org/r/128707/diff/


Testing
-------

Tested with three different captive portals and it worked perfectly.


Thanks,

Jan Grulich