Re: Review Request 128707: Add support for captive portals

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review99159
-----------------------------------------------------------




kded/portalmonitor.cpp (line 35)
<https://git.reviewboard.kde.org/r/128707/#comment66759>

    KNotification self-deletes when closed, so you need to create a new notification whenever you want to send it.
    
    (if you need to store it as a member, which I don't think you need to here, use QPointer)



kded/portalmonitor.cpp (line 39)
<https://git.reviewboard.kde.org/r/128707/#comment66758>

    Perhaps dialog-password is a better icon.
    
    Also use setIconName instead of pixmap



kded/portalmonitor.cpp (line 41)
<https://git.reviewboard.kde.org/r/128707/#comment66757>

    I don't think the average user knows what a "Captive Portal" is.
    
    Perhaps "You need to log in to this network." and use the network name as notifcation title or so.



kded/portalmonitor.cpp (line 58)
<https://git.reviewboard.kde.org/r/128707/#comment66760>

    Is it ensured that this notification doesn't constantly pop up, ie. does connectivity only change once I connect to a wifi (turns to "captive") and then again when I am authenticated? Ie. does it not cycle between various states at times?



kded/service.cpp (lines 57 - 60)
<https://git.reviewboard.kde.org/r/128707/#comment66761>

    You could have just initialized the members in the class definition above, ie.
    
    class Foo
    {
    public:
        Foo *bar = nullptr;
    }
    
    (just mentioning it, was there before this patch)


- Kai Uwe Broulik


On Sept. 14, 2016, 7:05 vorm., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 7:05 vorm.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza.
> 
> 
> Bugs: 365417
>     http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Adds portal monitor to our kded module, which checks NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive portal), then we open a QWebEngineView trying to load "http://kde.org" page which is supposed to be redirected to the captive portal page. Once user logs in and url changes, we re-check the connectivity again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -----
> 
>   kded/CMakeLists.txt 1f0613e 
>   kded/networkmanagement.notifyrc f95d94b 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> -------
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>