Re: Review Request 128707: Add support for captive portals

Jan Grulich <[email protected]> Wed, 14 Sep 2016 11:04:56 -0000

Newsgroups	gmane.comp.kde.knetworkmanager,gmane.comp.kde.devel.plasma,gmane.comp.kde.usability
Message-ID	<[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/
-----------------------------------------------------------

(Updated Sept. 14, 2016, 11:04 a.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza.


Changes
-------

Submitted with commit 4ead743a22d0d5b2264cf0aee5b00fa1d77153ea by Jan Grulich to branch master.


Bugs: 365417
    http://bugs.kde.org/show_bug.cgi?id=365417


Repository: plasma-nm


Description
-------

Adds portal monitor to our kded module, which checks NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive portal), then we open a QWebEngineView trying to load "http://kde.org" page which is supposed to be redirected to the captive portal page. Once user logs in and url changes, we re-check the connectivity again and close the web view if we are no longer behind the captive portal.


Diffs
-----

  kded/CMakeLists.txt 1f0613e 
  kded/networkmanagement.notifyrc f95d94b 
  kded/portalmonitor.h PRE-CREATION 
  kded/portalmonitor.cpp PRE-CREATION 
  kded/service.cpp 18ffd41 

Diff: https://git.reviewboard.kde.org/r/128707/diff/


Testing
-------

Tested with three different captive portals and it worked perfectly.


Thanks,

Jan Grulich