Re: Review Request 129533: expand all one level in tree view

> On Nov. 23, 2016, 4:35 a.m., Don Nguyen wrote:
> > I'm sorry, I have interpreted and used the term "expand all" incorrectly.  What I have implemented is just one part of what Heiko described in his two-step expand feature where it will expand all nodes one level.  I should describe this feature as "expand all one level", and change the function name from expandAll() to something like expandAllOneLevel().
> > 
> > I agree that the shortcut I had chosen needs to be changed and the functionality should be added to the context menu with a new shortcut.  What do you recommend for the text and shortcut key combination?  I want to avoid '*' because as Heiko mentioned, this means expand all under Windows and could cause confusion.
> 
> Heiko Tietze wrote:
>     While * is awkward it is the common shortcut. I have no idea for a _general_ replacement that would, for instance, also work in Krusader. Another feature that comes in mind is the opposite function: collapse all, ctrl+% (on numblock). However this function is also realized without collapsing the child nodes per cursor/arrow right.
> 
> Don Nguyen wrote:
>     What do you mean by the last part "However this function is also realized without collapsing the child nodes per cursor/arrow right"?

You can navigate in trees by using the cursor keys. Right opens the child nodes, and left closes. The cursor keys are sometimes known as arrow keys.


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129533/#review101063
-----------------------------------------------------------


On Nov. 23, 2016, 5:29 p.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129533/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 5:29 p.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Bugs: 196772
>     https://bugs.kde.org/show_bug.cgi?id=196772
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This allows the user to expand all expandable items in tree view by pressing '*'.  I've implemented this by adding expandAll() to the model, which is similar to QTreeView::expandAll(). The screenshots demonstrates the results after each press of '*'.  
> 
> Later, I can implement collapseAll() similarly, as well as the ability to expand selected folders if someone wants to tell me how those functionalities should be exposed (e.g., via menus or keypresses).
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodel.h 8a0df72 
>   src/kitemviews/kfileitemmodel.cpp 05f85a6 
>   src/kitemviews/kitemlistcontroller.cpp 1c86ff0 
>   src/kitemviews/kitemmodelbase.h bd5ca1d 
>   src/kitemviews/kitemmodelbase.cpp bf41b1c 
> 
> Diff: https://git.reviewboard.kde.org/r/129533/diff/
> 
> 
> Testing
> -------
> 
> manual testing, and make test passes
> 
> 
> File Attachments
> ----------------
> 
> screen1
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/a976337d-1537-40ca-97e4-925e8b603654__snapshot1.png
> screen2
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/b671f80a-455c-455c-8aa1-f1959a6d0c8b__snapshot2.png
> screen3
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/4a3770e9-7134-4d26-a5be-c66168a80252__snapshot3.png
> screen4
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/fe8a3788-f9ef-48bd-ba12-352a96e7de7b__snapshot4.png
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>