Re: Review Request 129533: Dolphin: expand all one level, expand all, and collapse all in details view mode

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129533/
-----------------------------------------------------------

(Updated Nov. 25, 2016, 11:03 p.m.)


Review request for Dolphin and KDE Usability.


Summary (updated)
-----------------

Dolphin: expand all one level, expand all, and collapse all in details view mode


Bugs: 196772
    https://bugs.kde.org/show_bug.cgi?id=196772


Repository: dolphin


Description (updated)
-------

Implemented functions:  Expand All One Level, Expand All, and Collapse All.  They are available via the context menu in details view mode as well as custom toolbar buttons as Thomas explained.  See screenshots.

I did not use the Ctrl+Shift+* shortcut because on my laptop, there is no numpad so it's not possible to generate that shortcut.


Diffs (updated)
-----

  src/dolphincontextmenu.cpp ed3f643 
  src/kitemviews/kfileitemmodel.h 8a0df72 
  src/kitemviews/kfileitemmodel.cpp 05f85a6 
  src/kitemviews/kitemmodelbase.h bd5ca1d 
  src/kitemviews/kitemmodelbase.cpp bf41b1c 
  src/views/dolphinview.h 0b0d819 
  src/views/dolphinview.cpp 4105628 
  src/views/dolphinviewactionhandler.h eb375b5 
  src/views/dolphinviewactionhandler.cpp 858f929 

Diff: https://git.reviewboard.kde.org/r/129533/diff/


Testing (updated)
-------

make test passes
manual testing including:
expand all on an Android SDK folder which yielded in 3180 folders, and 30993 files
collapse all on above situation
expand all on a directory that contains a symbolic link to a directory containing itself - operation will stop with error when expansion reaches a path that KCoreDirLister doesn't accept(see looptest screenshot) 
changing directories in the middle of an expand all operation
changing directories in the middle of a restore expanded directories operation 
canceling in the middle of an expand all operation
canceling in the middle of a restore expanded directories operation
canceling in the middle of an expand all operation or restore expand directory operation, and then expanding an item manually with mouse click
collapse all in the middle of an expand all operation
collapse all in the middle of a restore expanded directories operation


File Attachments (updated)
----------------

mainwindow
  https://git.reviewboard.kde.org/media/uploaded/files/2016/11/25/b4a961b6-3ed1-4115-876d-5d804c344f19__mainwindow.png
contextmenu
  https://git.reviewboard.kde.org/media/uploaded/files/2016/11/25/2b6a89a8-722e-4f88-a1ca-5da3f6c89140__contextmenu.png
looptest
  https://git.reviewboard.kde.org/media/uploaded/files/2016/11/25/f02b7e85-d0b3-4153-ae0d-e86a4ddfc916__looptest.png


Thanks,

Don Nguyen