Re: plugin plug: zealsearch

On Monday, 26 November 2018 20:05:37 CET René J.V. Bertin wrote:
> Hi,
> 
> Some of you may be familiar with the opensource docset browser, zeal
> (zealdocs.org). I've been working on a port of the old KDE4 plugin that
> allows to drive the zeal application as an external documentation browser
> from Kate and KDevelop.

Heya,

Sounds like you would want to propose that on the kwrite-devel mailing list 
instead (as it's based on KTextEditor). Potentially for integration upstream.

> I think it's now feature complete enough to do a shameless plug here:
> github.com/RJVB/zealsearch . After installation newly (re)started Kate and
> KDevelop sessions will have Zeal menus in the Tools menu and in the context
> menu. If can trigger a lookup of the selected text or (if there is none)
> the word under the cursor.

I had a quick look at the tree / commit history. I'd recommend to ...

- just remove any traces of KDE4 
- squash most your commits before proposing this to upstream 
  - Tings like "fix typo", etc., can go
  - The KF5 port itself likely just needs to be one big commit

Note: I have no personal interest in the plugin myself, but maybe the KTE 
authors have.

Regards,
Kevin


> Hope this is useful.
> 
> R.


-- 
Kevin Funk | [email protected] | http://kfunk.org

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQQ2TvpfY5VykH05KZnGTPVrE8rOXQUCW/5higAKCRDGTPVrE8rO
XeXiAKCHDYdOFNds9F/1YphndMZpivMqTQCePIyqlqsrrDh2zWYHs+xwc0zZgJM=
=P9FL
-----END PGP SIGNATURE-----