Re: Code review

On Wednesday, 21 August 2019 18:06:01 BST Ingo Klöcker wrote:
> Hi Peter,
> 
> On Mittwoch, 21. August 2019 17:51:01 CEST Peter Humphrey wrote:
> > Hello list,
> > 
> > Is this the proper place to point out any oddities I may find in trying to
> > make sense of KMail code? Some questions will no doubt be newbie grade,
> > becuase I've never looked at C++ before. I've extracted and configured the
> > source under ~/projects/myKmail/kmail-19.04.3.
> 
> The proper place for questions concerning the development of KMail is the
> kde- pim mailing list (https://mail.kde.org/mailman/listinfo/kde-pim).

Thanks Ingo. I should have thought of that.

> > The first thing I've noticed is that the file kmail-19.04.3/po/en_GB/
> > akonadi_mailfilteragent.po contains lots of four-line stanzas like this:
> > 
> > #: filterlogdialog.cpp:102
> > #, kde-format
> > msgid "Share..."
> > msgstr "Share..."
> > 
> > But one of them has an extra line:
> > 
> > #. i18n( "" ) );
> > #: filterlogdialog.cpp:136
> > #, kde-format
> > msgid "Log filter &rule evaluation"
> > msgstr "Log filter &rule evaluation"
> > 
> > First, what does the i18n line do, and second, why does it have an extra
> > closing bracket? Could anything go wrong because of this?
> 
> Having said the above, you shouldn't worry about the .po files. They are
> automatically generated from the source code and then translated by our
> translators usually using nice UI tools (I suppose).

Hm. All right; I won't.

-- 
Regards,
Peter.

Gentoo stable system, openrc-0.41.2
gcc 8.3.0, sys-kernel/gentoo-sources 4.19.66
QT 5.12.3, KDE frameworks 5.60.0, KDE plasma 5.15.5
KDE apps 19.04.3 incl KMail 19.04.3 (5.11.3), akonadi 19.04.3
dev-db/mariadb-10.2.22-r1, net-libs/webkit-gtk-2.24.2
x11-drivers/xf86-video-amdgpu 19.0.1
dev-libs/amdgpu-pro-opencl 19.10.785425-r1