Re: Barcode won't scan if Rendered Image is too small

Hi Andy

I've committed your changes. Thanks a lot! Besides your changes I've
added support for the font name, made a few touch-ups on the code and
updated the documentation. All in CVS, of course. I guess we'll need a
Beta2 once the whole thing cools down a bit.

I realized that not every font works on my machine. Even worse, most
fonts didn't work. I don't know, yet, if this is because of my code in
Java2DCanvasProvider where the actually text painting for bitmaps
happens or if it has something to do with the JDK I'm using. I'll have
to investigate further. Any help with that or anything else is highly
welcome.

May I request a few things for the next time you send a patch? Don't get
me wrong: for the first time this was fine. It's always best to send
patches against public CVS. That way the committer applying the patch
can see the changes before he puts them in his local codebase. It also
enables him to check what revision of a file the patch was made against.
Also, I suggest you reconfigure your Java editor to use spaces instead
of tabs. OpenSource projects mostly use spaces only because it's a lot
easier to handle (1 tab = 4 spaces according to the Sun Code Conventions).

If this is somewhat new there's a good page from Apache Cocoon that
describes how best to create patches. Although the text is a bit
Cocoon-specific it can easily be applied to Krysalis Barcode.
http://cocoon.apache.org/2.0/howto/howto-patch.html

This may be complicated at first, but when you've done this one or two
times it gets real easy and you can share the fun we all have developing
OpenSource software. :-)

Thanks again!

On 06.11.2003 02:18:39 Andrew Nelson wrote:
> Well I managed to get the size to modify but I can't seem to get the
> font to do anything.
> 
> Not sure what would be best but I have attached the files I modified. 
> Looking through your code I can tell allready that you are a far better
> developer than I so you may want to look through my code very carefully
> to be sure I haven't done anything dumb.  Anyhow if these changes should
> get commited it will be my first contribution to the opensource world so
> thank you much for the opportunity.  I don't have any idea why the font
> doesn't work but I haven't had a ton of time to work on this so maybe
> tommorow when I have more time I can try and see what exactly is going
> on.



Jeremias Maerki



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/