Re: Re: Distel now in the Jungerl

Martin Bjorklund <[email protected]> wrote:
> The best would be to make sure that distel works with the R10
> syntax_tools, and then check in that in jungerl.

Ok, I've now made sure that distel does not work with syntax_tools in
R10B.  Or actually I found a bug or two in erl_syntax.erl in R10B.
Nothing wrong with distel itself.  I've reported the bugs and I made a
quick-and-dirty ad-hoc fix which most certainly doesn't work for
anything other than this specific distel case.  

Also, it seems that the parse trees have changed a bit between R9 and
R10, so R9 parse tress are not R10 compatible.  Which means that even
if we added the latest syntax_tools to jungerl, it wouldn't work if
you run R9.

So right now, if you want to use the erl-who-calls function of distel
in R9, you have to grab the missing modules from the sourceforge
repository, and add them to your path.  And for R10 users, we have to
wait for a real patch to erl_syntax.erl, or apply the patch included
below.


/martin



lygna src> diff erl_syntax.erl.orig erl_syntax.erl 
574c574
<       {'try', _, _, _, _} -> try_expr;
---
>       {'try', _, _, _, _, _} -> try_expr;
5143c5143
<     Body = try_expr_body(Node),
---
>     [Body] = try_expr_body(Node),
5146c5146
<     {'try', Pos, Body, Clauses, Handlers}.
---
>     {'try', Pos, Body, Clauses, Handlers, []}.
5159c5159
<       {'try', _, Body, _, _} ->
---
>       {'try', _, Body, _, _, _} ->
5178c5178
<       {'try', _, _, Clauses, _} ->
---
>       {'try', _, _, Clauses, _, _} ->
5195c5195
<       {'try', _, _, _, Handlers} ->
---
>       {'try', _, _, _, Handlers, _} ->
6016c6016
<                   [[try_expr_body(T)],
---
>                   [try_expr_body(T),



-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click