Re: ANTLR Jars

On Sun, Jun 29, 2014 at 6:13 AM, Jeff Allen <[email protected]> wrote:
> Frank committed:
> http://hg.python.org/jython/rev/5e7462875b63
> Restore antlr-runtime-3.1.3.jar. It is needed to create a final
> distribution, which doesn't need to bundle the entire antlr
> distribution, just the runtime.
>
> Oh well, I was half right by getting rid of antlr-2.7.7. Sorry.
Thanks for the cleanup - I wasn't sure when I saw the commit go by and
should have looked closer.


> However, I'm puzzled. This is a reason I thought of for sparing the
> -runtime JAR. When I looked in my installation of Jython 2.7b3, from the
> soft-launch, it had all the ANTLR JARs, so I concluded we were not
> selective. Is this an error in our packaging?
I bet the jars that end up in javalib/ are unnecessary, but I'd have
to investigate to be sure. The jars that are needed for Jython to
function are actually jarjar'ed into jython.jar. For example if you
run:

jar tf jython.jar | grep antlr

You'll see classes from antlr, but they are only from the runtime jar.
Also you'd see that they look like this:

org/python/antlr/runtime/tree/TreePatternLexer.class

Where the name has mangled by jarjar to start with org/python/ so that
the antlr (and other libs) we run won't conflict with code that uses
any of these libraries. Otherwise conflicts between different versions
of the libs would cause no end of trouble.

-Frank

------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft