Re: [code-review] Please review String::FlexMatch
Marcel GrĂ¼nauer <[email protected]> Fri, 5 Sep 2003 11:58:39 +0200
| Newsgroups | gmane.comp.lang.perl.code-review-ladder |
|---|---|
| Message-ID | <[email protected]> |
On Donnerstag, September 4, 2003, at 04:14 Uhr, Tony Bowden wrote: > I think we have two completely different ideas of what _deeply_ means > here. > > It's documented as "descend a structure and apply is()", not "fiddle > around as deeply as possible with each element to make sure they're the > same". I completely agree. Do you think the extra line in Test::More::_deep_check(), namely defined(overload::Method($_, '""')) && $_ = "$_" for $e1, $e2; as discussed in a previous mail would enforce this behaviour? If so, I could write a patch and tests against 5.8.1-RC4 and propose them to p5p. Marcel